Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/adjusts template-spec checks to ensure template metadata is valid and to detect potential template file collisions, including new coverage for Web Components (igc-ts) templates. This aligns with the intent of PR #1562 to harden template correctness checks.
Changes:
- Add a new
webcomponents-spec.tsto verify Web Components templates have IDs and do not collide internally forigc-ts. - Initialize the CLI core
Appcontainer in template specs (beforeAll) to ensure filesystem-backed utilities work during tests. - Improve collision-test assertion messages by switching to
withContext(...).toBeTruthy().
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/templates/webcomponents-spec.ts | New spec covering Web Components template IDs and igc-ts collision checks. |
| spec/templates/react-spec.ts | Adds App.initialize() and improves collision assertion context formatting. |
| spec/templates/jquery-spec.ts | Adds App.initialize() and updates ID assertion to use withContext. |
| spec/templates/angular-spec.ts | Adds App.initialize() and improves collision assertion context formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
damyanpetev
changed the title
kdinev
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick 7b0d992 from #1562 that got lost merge conflict resolutions somehow.
Edit: Strike that, picking both commits from PR since both are gone from master.